Skip to content

perf: chunk js api #10502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 3, 2025
Merged

perf: chunk js api #10502

merged 9 commits into from
Jul 3, 2025

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented May 28, 2025 •
edited
Loading

Summary

Remove Chunk class in JavaScript side, directly use binding.Chunk to improve performance.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented May 28, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit be898bc
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/6865eee76f945300080410ca

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: performance release: performance related release(mr only) labels May 28, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10502 will not alter performance

Comparing perf-chunk-js-api (be898bc) with main (49a5d90)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 16 untouched benchmarks

@SyMind SyMind marked this pull request as ready for review May 29, 2025 05:01
@SyMind SyMind marked this pull request as draft May 29, 2025 05:01
@SyMind SyMind force-pushed the perf-chunk-js-api branch from 2b80f88 to b6ff707 Compare July 2, 2025 11:42
@SyMind SyMind force-pushed the perf-chunk-js-api branch from b6ff707 to 1b1e36b Compare July 2, 2025 11:55
@SyMind SyMind force-pushed the perf-chunk-js-api branch from 0ae2c1c to 6a8aabd Compare July 3, 2025 02:04
@SyMind SyMind marked this pull request as ready for review July 3, 2025 02:26
@SyMind SyMind requested a review from ahabhgk July 3, 2025 02:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

📦 Binary Size-limit

Comparing binary size with Commit: chore: CI enable binary size limit (#10875) by pshu

❌ Size increased by 384bytes from 61.43MB to 61.43MB (⬆️0.00%)

@SyMind SyMind merged commit 41f1148 into main Jul 3, 2025
67 of 69 checks passed
@SyMind SyMind deleted the perf-chunk-js-api branch July 3, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyMind @ahabhgk @stormslowly